Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Don't use the keyword "self" #11315

Merged
merged 1 commit into from
Jul 31, 2024
Merged

ENH Don't use the keyword "self" #11315

merged 1 commit into from
Jul 31, 2024

Conversation

GuySartorelli
Copy link
Member

Wasn't included in #11313 because this code is new in the 5 branch.

Fixes https://github.com/silverstripe/silverstripe-framework/actions/runs/10152021344/job/28072530978

Can't use keyword 'self'. Use 'Environment' instead.

Issue

@GuySartorelli GuySartorelli mentioned this pull request Jul 29, 2024
Closed
@GuySartorelli GuySartorelli changed the title ENH D't use the keyword "self" ENH Don't use the keyword "self" Jul 29, 2024
@emteknetnz emteknetnz merged commit 9091ecf into silverstripe:5 Jul 31, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/no-keyword-self branch July 31, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz